Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

demo-166-storage-api-webapis - Done #172

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

demo-166-storage-api-webapis - Done #172

wants to merge 3 commits into from

Conversation

ade1705
Copy link

@ade1705 ade1705 commented Oct 12, 2022

Description

Implemented demo for Selection API

Fixes 166

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Oct 12, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
webapis-playground ✅ Ready (Inspect) Visit Preview Oct 18, 2022 at 7:20PM (UTC)

@atapas
Copy link
Owner

atapas commented Oct 13, 2022

@ade1705 Hey please resolve the conflict so that I can start review?

@atapas atapas assigned atapas and ade1705 and unassigned atapas Oct 13, 2022
@ade1705
Merge branch 'master' of https://github.com/ade1705/webapis-playground …
141ad16 
…into demo-166-storage-api-webapis

� Conflicts:
�	src/modules/apis/data.ts
@ade1705
Copy link
Author

ade1705 commented Oct 14, 2022

@ade1705 Hey please resolve the conflict so that I can start review?

@atapas conflict resolved

@atapas atapas added the hacktoberfest hacktoberfest label Oct 17, 2022
atapas
atapas requested changes Oct 17, 2022
View reviewed changes
Copy link
Owner

@atapas atapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ade1705 Do not use alerts. Let's have a section in the page to show the success and error messages.

@ade1705
Copy link
Author

ade1705 commented Oct 18, 2022

@ade1705 Do not use alerts. Let's have a section in the page to show the success and error messages.

@atapas I removed the alerts and added a section in the page to show the messages

@ade1705 ade1705 requested a review from atapas October 18, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atapas atapas Awaiting requested review from atapas

Requested changes must be addressed to merge this pull request.

Assignees

@ade1705 ade1705

Labels
hacktoberfest hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

✨ [New Demo Request]: Add Storage API
2 participants
@ade1705 @atapas