Pull Request for ROS2-Jazzy Dockerfile #470
Conversation
| @@ -1,4 +1,5 @@ | |||
| { | |||
| "files.eol": "\n", | |||
There was a problem hiding this comment.
I encountered a problem with line endings on Linux and Windows. Unix-based systems, like Linux and macOS, use the LF (Line Feed) character for line breaks by default. However, Windows is different and uses both CR (Carriage Return) and LF (Line Feed) characters for line breaks.
To solve this, I added a line of code to ensure that the line endings are always set to LF. This approach works on both Linux and Windows without any issues.
There was a problem hiding this comment.
I only need the Dockerfiles related to ROS2, so I deleted ros. If it's necessary to add them back later, I'll do so.
There was a problem hiding this comment.
Did https://github.com/athackst/dockerfiles/blob/main/ros2/jazzy.Dockerfile not work for you?
I added Jazzy support in #461
There was a problem hiding this comment.
There were some small changes needed for certain commands, as the previous ones were not working. I've updated them accordingly.
There was a problem hiding this comment.
What exactly wasn't working? What did you change?
There was a problem hiding this comment.
In 'Set up auto-completion for user,' line 104, I believe the command has changed.
There was a problem hiding this comment.
What exactly wasn't working? What did you change?
Dear Allison,
I hope you are doing well.
I wanted to inform you that, based on the work you've done, I have created a ROS2-Jazzy Dockerfile. I have also submitted a pull request to merge it into the main repository. I would appreciate it if you could review the request and approve it if everything looks good.
Please let me know if you have any questions or need further adjustments.
Best regards,
Mahdi