Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyter Modify button #84

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

EiriniGeorgiaDimitriou
Copy link
Contributor

Add a function in ProjectController to handle projectType = 4 for Jupyter modifications.

Copy link
Collaborator

@deligianp deligianp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: minor changes (1)

  • Remove flash message from source code

@@ -84,6 +84,9 @@ public function beforeAction($action)
return false;
}

// Set the flash message
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ad-hoc flash message needs to be removed from the source code.

Amend comment if possible so that flash message does not pollute commit history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants