-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test place_connection()
more
#209
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8299597160Details
💛 - Coveralls |
This does not work as it should yet because place_connection() sets up its own TEManager instance with topologies populated from the DB.
This was removed on merging because swagger_server/test/__init__.py was gone.
To be removed later
To be removed later
… 102.place-connection-tests
This accidentally got deleted during merge. I believe EXPOSE is a no-op and should go anyway, but let us test that theory separately.
congwang09
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #102. Changes:
TEManager
instance throughout the app, thus avoidingTopologyManager
invocations. The latter probably should be a hidden implementation detail of PCE; we should tackle that separately.place_connection()
under various conditions.Getting this merged is a pre-condition for getting to #225 (handling connection deletions). This is probably incomplete and there are likely to be issues, but we can test address them later once things are in place.