Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ISO3166 2 lvl4 #228

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Add ISO3166 2 lvl4 #228

merged 4 commits into from
Feb 13, 2024

Conversation

congwang09
Copy link
Contributor

This is the last step for adding iso3166_2_lvl4.

@coveralls
Copy link

coveralls commented Feb 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7881144160

Details

  • -4 of 8 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 38.214%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/models/location.py 4 8 50.0%
Totals Coverage Status
Change from base Build 7821205707: 0.08%
Covered Lines: 609
Relevant Lines: 1432
💛 - Coveralls

@YufengXin
Copy link
Collaborator

@congwang09 "black -check" error? need to run black?

@congwang09
Copy link
Contributor Author

@congwang09 "black -check" error? need to run black?

True, somehow black stopped working on my vscode. It's fixed.

@congwang09 congwang09 merged commit 3aff39a into main Feb 13, 2024
9 checks passed
@congwang09 congwang09 deleted the add-iso3166_2_lvl4 branch February 13, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YufengXin YufengXin YufengXin approved these changes

@sajith sajith Awaiting requested review from sajith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@congwang09 @coveralls @YufengXin