Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return for place connection #231

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix return for place connection #231

merged 1 commit into from
Feb 14, 2024

Conversation

congwang09
Copy link
Contributor

Resolves: #230

Fix return for place_connection(). In the future, the connection ID should be returned, to be used when we delete connection. Will address in a follow up PR.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7904583842

Details

  • -1 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 38.214%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/handlers/connection_handler.py 0 1 0.0%
Totals Coverage Status
Change from base Build 7881174666: 0.0%
Covered Lines: 609
Relevant Lines: 1432

💛 - Coveralls

@congwang09 congwang09 merged commit 3a1ab8b into main Feb 14, 2024
9 checks passed
@congwang09 congwang09 deleted the fix-place-connection branch February 14, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connection handler is sending the breakdown twice for the SDX LC
3 participants