-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDX message when no topology is available yet #319
Conversation
Pull Request Test Coverage Report for Build 10492899944Details
💛 - Coveralls |
It is time to drop Python 3.8 from the test matrix. It is old and unsupported and we do not need to maintain compatibility with it anyway. |
The test failure is because we're trying to use the latest pytest version, which pip can't install:
I don't think we care to resolve this conflict. Instead, we can just drop Python 3.8 from the test matrix. |
@congwang09 #321 should resolve the broken test. |
@congwang09 I don't understand the new test failure ("coveralls: command not found"??). It has nothing to do with anything we did. Please go ahead and merge this. Let us figure out the coveralls issue separately. |
This is the issue: coverallsapp/github-action#219. |
Resolves: #172
When there's no topology in SDX controller, if place a connection, SDX controller will return "Could not generate a graph". This is a bit ambiguous. Making the message more clear as "No SDX topology found".
Also, since we are in development phase, changed default logging to DEBUG to get more logging when something goes wrong.