Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDX message when no topology is available yet #319

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

congwang09
Copy link
Contributor

Resolves: #172

When there's no topology in SDX controller, if place a connection, SDX controller will return "Could not generate a graph". This is a bit ambiguous. Making the message more clear as "No SDX topology found".

Also, since we are in development phase, changed default logging to DEBUG to get more logging when something goes wrong.

@congwang09 congwang09 requested review from sajith and YufengXin August 21, 2024 15:31
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10492899944

Details

  • 1 of 3 (33.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 57.931%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/init.py 1 2 50.0%
sdx_controller/handlers/connection_handler.py 0 1 0.0%
Totals Coverage Status
Change from base Build 10473608051: 0.0%
Covered Lines: 1038
Relevant Lines: 1858

💛 - Coveralls

@sajith
Copy link
Member

sajith commented Aug 21, 2024

It is time to drop Python 3.8 from the test matrix. It is old and unsupported and we do not need to maintain compatibility with it anyway.

@sajith
Copy link
Member

sajith commented Aug 21, 2024

The test failure is because we're trying to use the latest pytest version, which pip can't install:

ERROR: Cannot install sdx-controller and sdx-controller[test]==0.1.dev1+gc8c568b because these package versions have conflicting dependencies.

The conflict is caused by:
    sdx-controller[test] 0.1.dev1+gc8c568b depends on pluggy>=0.3.1; extra == "test"
    pytest 8.3.2 depends on pluggy<2 and >=1.5
    sdx-controller[test] 0.1.dev1+gc8c568b depends on pluggy>=0.3.1; extra == "test"
    pytest 8.3.1 depends on pluggy<2 and >=1.5
    sdx-controller[test] 0.1.dev1+gc8c568b depends on pluggy>=0.3.1; extra == "test"
    pytest 8.3.0 depends on pluggy<2 and >=1.5
    sdx-controller[test] 0.1.dev1+gc8c568b depends on pluggy>=0.3.1; extra == "test"
    pytest 8.2.2 depends on pluggy<2.0 and >=1.5
    sdx-controller[test] 0.1.dev1+gc8c568b depends on pluggy>=0.3.1; extra == "test"
    pytest 8.2.1 depends on pluggy<2.0 and >=1.5
    sdx-controller[test] 0.1.dev1+gc8c568b depends on pluggy>=0.3.1; extra == "test"
    pytest 8.2.0 depends on pluggy<2.0 and >=1.5
ERROR: ResolutionImpossible: for help visit https://pip.pypa.io/en/latest/topics/dependency-resolution/#dealing-with-dependency-conflicts

I don't think we care to resolve this conflict. Instead, we can just drop Python 3.8 from the test matrix.

@sajith sajith mentioned this pull request Aug 21, 2024
@sajith
Copy link
Member

sajith commented Aug 21, 2024

@congwang09 #321 should resolve the broken test.

@sajith
Copy link
Member

sajith commented Aug 21, 2024

@congwang09 I don't understand the new test failure ("coveralls: command not found"??). It has nothing to do with anything we did. Please go ahead and merge this. Let us figure out the coveralls issue separately.

@sajith
Copy link
Member

sajith commented Aug 21, 2024

This is the issue: coverallsapp/github-action#219.

@congwang09 congwang09 merged commit 16543a6 into main Aug 21, 2024
11 checks passed
@congwang09 congwang09 deleted the update-sdx-message branch August 21, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error handling when latest topology is not available in DB
3 participants