Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PATCH connection #324

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Implement PATCH connection #324

merged 2 commits into from
Aug 30, 2024

Conversation

congwang09
Copy link
Contributor

@congwang09 congwang09 commented Aug 30, 2024

Resolves: #235

Implement PATCH endpoint. And replaced connection_id with service_id, for consistency.

@congwang09 congwang09 requested review from sajith and YufengXin August 30, 2024 19:57
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10638427574

Details

  • 22 of 45 (48.89%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 57.762%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/handlers/connection_handler.py 8 10 80.0%
sdx_controller/controllers/l2vpn_controller.py 14 35 40.0%
Totals Coverage Status
Change from base Build 10569856636: -0.4%
Covered Lines: 1040
Relevant Lines: 1868

💛 - Coveralls

Copy link
Collaborator

@YufengXin YufengXin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: patch -> delete then reprovisioning.

The new connection will be given a new service_id?

@congwang09
Copy link
Contributor Author

Note: patch -> delete then reprovisioning.

The new connection will be given a new service_id?

Yes, it'll have a new service_id, since we delete the old connection, and we keep the old connection in DB, just mark it as "deleted". There'll be conflict if we keep the same service_id.

@congwang09 congwang09 merged commit 9afb868 into main Aug 30, 2024
11 checks passed
@congwang09 congwang09 deleted the patch-connection branch August 30, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support patch/change operation for an existing connection request
3 participants