Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle connection requests with VLAN set to "any" #327

Merged
merged 14 commits into from
Sep 20, 2024
Merged

Handle connection requests with VLAN set to "any" #327

merged 14 commits into from
Sep 20, 2024

Conversation

sajith
Copy link
Member

@sajith sajith commented Sep 19, 2024 •
edited
Loading

Resolves #320 and #314.

@sajith sajith self-assigned this Sep 19, 2024
@sajith
Fix copy-pasta typo
23a3d60
@sajith
Modify the connection request so that we have a solvable one
fc00e9d 
PCE changed so that it rejects invalid requests now; but the change
has not percolated down to datamodel.  We use the example connection
request from datamodel.
@sajith
Correct another copy-pasta error
0f05e53
@coveralls
Copy link

coveralls commented Sep 19, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10949182225

Details

  • 35 of 36 (97.22%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 58.299%
Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/handlers/connection_handler.py 32 33 96.97%
Totals Coverage Status
Change from base Build 10729550655: 0.5%
Covered Lines: 1084
Relevant Lines: 1918
💛 - Coveralls

@sajith sajith linked an issue Sep 19, 2024 that may be closed by this pull request
SDX-Controller should display vlan field for a connection/l2vpn instead of vlan_range #314
Closed
@sajith sajith marked this pull request as ready for review September 19, 2024 21:29
YufengXin
YufengXin approved these changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@YufengXin YufengXin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@sajith sajith merged commit a6b251d into main Sep 20, 2024
11 checks passed
@sajith sajith deleted the 320.any-vlan-requests branch September 20, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YufengXin YufengXin YufengXin approved these changes

@italovalcy italovalcy Awaiting requested review from italovalcy

@congwang09 congwang09 Awaiting requested review from congwang09

Assignees

@sajith sajith

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sajith @coveralls @YufengXin