Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LC-X for topo db key #329

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Use LC-X for topo db key #329

merged 2 commits into from
Oct 9, 2024

Conversation

congwang09
Copy link
Contributor

This PR reverts part of #328, to use LC-X as database key. Because using domain name as db key caused some issues on provisioning connection.

@congwang09 congwang09 requested review from sajith and YufengXin October 3, 2024 15:30
@coveralls
Copy link

coveralls commented Oct 3, 2024

Pull Request Test Coverage Report for Build 11164979631

Details

  • 0 of 7 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 58.374%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/handlers/lc_message_handler.py 0 2 0.0%
sdx_controller/messaging/rpc_queue_consumer.py 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
sdx_controller/handlers/lc_message_handler.py 1 24.0%
Totals Coverage Status
Change from base Build 11131304124: -0.02%
Covered Lines: 1086
Relevant Lines: 1918

💛 - Coveralls

Copy link
Collaborator

@YufengXin YufengXin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: 1. domain_name = self.parse_helper.find_domain_name(msg_id, ":")
Now: LC-X: need to be deterministic for next PR

@congwang09 congwang09 merged commit 57fabe7 into main Oct 9, 2024
11 checks passed
@congwang09 congwang09 deleted the use-lc-x-for-topo-db-key branch October 9, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants