Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use get_connection_status when listing connections #338

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

congwang09
Copy link
Contributor

@congwang09 congwang09 commented Oct 16, 2024

Resolves: #333, #336

Call get_connection_status() for all connections, when listing connections.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11374100137

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.021%

Totals Coverage Status
Change from base Build 11257380760: 0.0%
Covered Lines: 1070
Relevant Lines: 1910

💛 - Coveralls

Copy link
Collaborator

@YufengXin YufengXin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make sure the returned response in valid Json format for Meican to show...

@congwang09
Copy link
Contributor Author

Need to make sure the returned response in valid Json format for Meican to show...

The new format should be right. Example:

{
  "044d9f8a-ad47-4e08-8044-33bf56fe3d5d": {
    "044d9f8a-ad47-4e08-8044-33bf56fe3d5d": {
      "description": null,
      "endpoints": [
        {
          "port_id": "urn:sdx:port:ampath.net:Novi03:1",
          "vlan": "101"
        },
        {
          "port_id": "urn:sdx:port:ampath.net:Novi03:1",
          "vlan": "4095"
        },
        {
          "port_id": "urn:sdx:port:tenet.ac.za:Novi07:1",
          "vlan": "4095"
        },
        {
          "port_id": "urn:sdx:port:tenet.ac.za:Novi07:1",
          "vlan": "101"
        }
      ],
      "name": "fabrictest1",
      "service_id": "044d9f8a-ad47-4e08-8044-33bf56fe3d5d"
    }
  },
  "3231103a-d20b-4ca0-b254-2ddece2b4be0": {
    "3231103a-d20b-4ca0-b254-2ddece2b4be0": {
      "description": null,
      "endpoints": [
        {
          "port_id": "urn:sdx:port:ampath.net:Novi03:1",
          "vlan": "4094"
        },
        {
          "port_id": "urn:sdx:port:ampath.net:Novi03:1",
          "vlan": "4093"
        },
        {
          "port_id": "urn:sdx:port:tenet.ac.za:Novi07:1",
          "vlan": "4094"
        },
        {
          "port_id": "urn:sdx:port:tenet.ac.za:Novi07:1",
          "vlan": "4093"
        }
      ],
      "name": "fabrictest1",
      "service_id": "3231103a-d20b-4ca0-b254-2ddece2b4be0"
    }
  }
}

@congwang09 congwang09 merged commit ad705e8 into main Oct 16, 2024
11 checks passed
@congwang09 congwang09 deleted the use-get_connection_status-for-list-conn branch October 16, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

endpoints returns vlan_range instead of vlan
3 participants