Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not duplicate service_id when listing connections #339

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

congwang09
Copy link
Contributor

A quick fix when listing connections. Previously:

{
  "a0e32889-ec1f-426f-9881-d071d1cd301e": {
    "a0e32889-ec1f-426f-9881-d071d1cd301e": {
    "description": null,
    "endpoints": [
      {
        "port_id": "urn:sdx:port:ampath.net:Novi03:1",
        "vlan": "101"
      },
      {
        "port_id": "urn:sdx:port:ampath.net:Novi03:1",
        "vlan": "4095"
      },
      {
        "port_id": "urn:sdx:port:tenet.ac.za:Novi07:1",
        "vlan": "4095"
      },
      {
        "port_id": "urn:sdx:port:tenet.ac.za:Novi07:1",
        "vlan": "101"
      }
    ],
    "name": "fabrictest1",
    "service_id": "20caef72-b799-4781-9b80-e6c5832376f9"
  }
  }
}

new:

{
  "a0e32889-ec1f-426f-9881-d071d1cd301e": {
    "description": null,
    "endpoints": [
      {
        "port_id": "urn:sdx:port:ampath.net:Novi03:1",
        "vlan": "101"
      },
      {
        "port_id": "urn:sdx:port:ampath.net:Novi03:1",
        "vlan": "4095"
      },
      {
        "port_id": "urn:sdx:port:tenet.ac.za:Novi07:1",
        "vlan": "4095"
      },
      {
        "port_id": "urn:sdx:port:tenet.ac.za:Novi07:1",
        "vlan": "101"
      }
    ],
    "name": "fabrictest1",
    "service_id": "20caef72-b799-4781-9b80-e6c5832376f9"
  }
}

@congwang09 congwang09 requested a review from YufengXin October 18, 2024 15:42
@coveralls
Copy link

coveralls commented Oct 18, 2024

Pull Request Test Coverage Report for Build 11406804029

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.021%

Totals Coverage Status
Change from base Build 11374221737: 0.0%
Covered Lines: 1070
Relevant Lines: 1910

💛 - Coveralls

@congwang09 congwang09 merged commit 5cc5fe8 into main Oct 18, 2024
11 checks passed
@congwang09 congwang09 deleted the remove-duplicate-service-id branch October 18, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants