Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup topology handling logic #346

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Conversation

congwang09
Copy link
Contributor

We used to use LC-1,2,3 to represent the LCs, to be easier to loop through the topologies from db when SDX starts up. Now we have the list of LC domain names saved in db, so we don't need the LC counter any more. This can simplify the logic for handling topologies.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11575603928

Details

  • 1 of 19 (5.26%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 56.886%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sdx_controller/handlers/lc_message_handler.py 0 2 0.0%
sdx_controller/messaging/rpc_queue_consumer.py 1 17 5.88%
Files with Coverage Reduction New Missed Lines %
sdx_controller/handlers/lc_message_handler.py 2 30.0%
Totals Coverage Status
Change from base Build 11524951004: 0.1%
Covered Lines: 1107
Relevant Lines: 1946

💛 - Coveralls

@congwang09 congwang09 merged commit fc230f2 into main Oct 29, 2024
11 checks passed
@congwang09 congwang09 deleted the cleanup-topology-handling-logic branch October 29, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants