Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle out-of-range VLANs gracefully #357

Merged
merged 7 commits into from
Nov 15, 2024
Merged

Handle out-of-range VLANs gracefully #357

merged 7 commits into from
Nov 15, 2024

Conversation

sajith
Copy link
Member

@sajith sajith commented Nov 14, 2024

Resolves #356.

@sajith sajith self-assigned this Nov 14, 2024
@coveralls
Copy link

coveralls commented Nov 14, 2024

Pull Request Test Coverage Report for Build 11859274966

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 56.93%

Totals Coverage Status
Change from base Build 11799592589: 0.1%
Covered Lines: 1109
Relevant Lines: 1948

💛 - Coveralls

@sajith sajith force-pushed the 356.vlan-out-of-range branch from 474f08a to c0389de Compare November 15, 2024 15:30
@sajith
Copy link
Member Author

sajith commented Nov 15, 2024

@italovalcy The request you've provided in #356 is this:

{
  "name": "VLAN between AMPATH/300 and TENET/300",
  "endpoints": [
    {
      "port_id": "urn:sdx:port:ampath.net:Ampath3:50",
      "vlan": "300"
    },
    {
      "port_id": "urn:sdx:port:tenet.ac.za:Tenet03:50",
      "vlan": "any"
    }
  ]
}

But that does not produce an out of range error (see test status at commit c0389de), so I used 30000 for endpoints.0.vlan instead. The error you reported should be fixed once this PR gets merged. Thank you for the helpful error description!

@sajith sajith marked this pull request as ready for review November 15, 2024 15:54
Copy link
Collaborator

@YufengXin YufengXin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-:)

@sajith sajith merged commit cb02301 into main Nov 15, 2024
11 checks passed
@sajith sajith deleted the 356.vlan-out-of-range branch November 15, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Internal server error while submitting a request with VLAN out of the allowed range
3 participants