Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Desk: add dedicated error handler #1434

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

Ahuahuachi
Copy link
Contributor

The default AtlassianRestAPI exception handler raises an HTTPError with an empty error message when using the Service Desk API.
The dedicated exception handler attempts to get the error message from the "errorMessage" (singular) property instead of the "errorMessages" (plural) property

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 34.35%. Comparing base (795705b) to head (b88058e).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
atlassian/service_desk.py 16.66% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1434      +/-   ##
==========================================
- Coverage   34.38%   34.35%   -0.03%     
==========================================
  Files          46       46              
  Lines        8586     8598      +12     
  Branches     1601     1603       +2     
==========================================
+ Hits         2952     2954       +2     
- Misses       5511     5519       +8     
- Partials      123      125       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gonchik gonchik merged commit 388a340 into atlassian-api:master Aug 29, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants