Update server-side-rendering to include style[data-cmpld] #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Changes** - Update examples to include `data-cmpld=true` as this may help readers deal with edge cases. - Add an additional selector to the Selector workarounds
mattrq
requested review from
JakeLane,
pancaspe87,
liamqma,
dddlr and
zesmith2
as code owners
|
✅ Deploy Preview for compiled-css-in-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JakeLane
approved these changes
Dec 16, 2024
dddlr
reviewed
Dec 19, 2024
| @@ -19,9 +19,9 @@ like so: | |||
|
|
|||
| <!-- prettier-ignore --> | |||
| ```html | |||
| <style>._k48pni7l{font-weight:600}</style> | |||
| <style data-cmpld=true>._k48pni7l{font-weight:600}</style> | |||
There was a problem hiding this comment.
data-cmpld=true should be data-cmpld="true"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
data-cmpld=trueas this may help readers deal with edge cases.What is this change?
Describe what change you are making here.
Why are we making this change?
Give the full context for your change here.
How are we making this change?
(Optional.)
PR checklist
Don't delete me!
I have...
website/