Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NONE: Add basic frontend routing for the admin page #113

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

Roystbeef
Copy link
Collaborator

Adding the basic routing/skeleton for the admin configuration page and the API calls it makes to make these decisions.

This is blocked on #112 for the /checkAuth route to succeed since it currently does not support the context-qsh but you can get around this locally for testing by applying the changes in #106

Screenshots

Skeleton page for logging in
admin blank login
Skeleton page for connecting a team
admin blank connect a team

Skeleton page for rendering the connected teams
admin blank connected teams

Test Plan

  • Assert that when you haven't connected, you are shown the continue button
  • Assert that after clicking continue, you are prompted to install the app
  • Assert that upon success, when you go back to the original page, you are shown the connect a team placeholder
  • Make a post request to connect a figma team for this connection id and refresh the configure page
  • Assert that you are shown the connected teams placeholder now

@Roystbeef Roystbeef requested a review from jvrankul23 October 23, 2023 16:15
@Roystbeef Roystbeef force-pushed the roy/admin/basic-routing branch from 318f4c4 to aebb21c Compare October 24, 2023 23:20
@Roystbeef Roystbeef merged commit 28288cf into main Oct 25, 2023
1 check passed
@Roystbeef Roystbeef deleted the roy/admin/basic-routing branch October 25, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants