MDTZ-1089: Refactor Figma webhook error handling (PR 2/3) #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -75,44 +75,6 @@ describe('/admin/auth', () => { | |||
| .expect({ authorized: true }); | |||
| }); | |||
|
|
|||
There was a problem hiding this comment.
note: Add new integration tests, reorder existing ones and resolve test flakiness (caused by a time-bound JWT token).
| @@ -70,41 +70,6 @@ describe('/auth', () => { | |||
| .expect({ type: '3LO', authorized: true }); | |||
| }); | |||
|
|
|||
| it('should return a response indicating that user is not authorized if no credentials stored', async () => { | |||
There was a problem hiding this comment.
note: Add new integration tests, reorder existing ones and resolve test flakiness (caused by a time-bound JWT token).
| export const FIGMA_WEBHOOK_EVENT_REQUEST_SCHEMA: JSONSchemaTypeWithId<{ | ||
| body: FigmaWebhookEventPayload; | ||
| }> = { | ||
| export const FIGMA_WEBHOOK_EVENT_REQUEST_SCHEMA = { |
There was a problem hiding this comment.
note: Improve schema definition by using JSON Schema Discriminator (e.g., file_key gets required for the FILE_UPDATE event but is still optional for PING).
|
|
||
| export type FigmaWebhookEventPayload = { | ||
| readonly event_type: FigmaWebhookEventType; |
There was a problem hiding this comment.
note: Remove fields the app is not interested in.
akostevich-atlassian
changed the title
akostevich-atlassian
changed the title
stannnous
approved these changes
Oct 27, 2023
akostevich-atlassian
deleted the
MDTZ-1089-error-handling-improvements-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
FigmaWebhookServicewithfigmaWebhookAuthMiddlewarefor authenticating Figma webhook events.ValidationErrorand related error handling.checkAuthendpoints (caused by the usage of time-bound JWT tokens).