NONE: Update our webhook route to send a status code back immediately #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akostevich-atlassian
requested changes
Jan 29, 2024
akostevich-atlassian
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were noticing a lot of retries when handling webhook events. This is because Figma's webhook service has a 4 second timeout which the asynchronous code we were running in this route was blocking.
To address this, we are updating the route to respond with a 200 status code in the route after starting our asynchronous logic
Unfortunately, as part of this, we do need to add some specific testing logic in order for our integration tests to properly wait for all the asynchronous logic succeeds.
Test Plan