HL-812 Bump node Docker base image to 20.15.0-bookworm-slim for VULN-1313552 #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzhusong-atlassian-github-account
requested review from
stannnous,
jvrankul23 and
akostevich-atlassian
jzhusong-atlassian-github-account
changed the title
akostevich-atlassian
approved these changes
Jul 24, 2024
| @@ -1,4 +1,4 @@ | |||
| FROM node:20.12.2-bookworm-slim@sha256:72f2f046a5f8468db28730b990b37de63ce93fd1a72a40f531d6aa82afdf0d46 as build | |||
| FROM node:20.15.0-bookworm-slim@sha256:b5e567dc37677a1485cec21e2f0c0df517c7afe40c1ebc28248c41520c77b3d0 as build | |||
There was a problem hiding this comment.
nitpick: Jeming, please, search for 20.12.2 in the codebase: there are some other places where we need to bump up the Node.js version for the consistency.
Please, check:
package.json.nvmrc
akostevich-atlassian
deleted the
issue/HL-812-bump-node-docker-base-image-for-vuln
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://asecurityteam.atlassian.net/browse/VULN-1313552
Vulnerability is due to the Docker base image used (node:20.12.2-bookworm-slim), which uses
debian/systemd 252.22-1~deb12u1(reference)We need to bump this Docker base image up to node:20.15.0-bookworm-slim, which is the closest version that uses
debian/systemd 252.26-1~deb12u2(reference), which is enough to fix the VULN, as the VULN suggests: