Implement Force Removal Taint Logic #246
Conversation
jackcasey-visier
changed the title
jackcasey-visier
changed the title
awprice
requested review from
awprice,
Jacobious52,
vincentportella and
mwhittington21
|
Thank you for contributing this @jackcasey-visier! Overall approach looks good to me - would be good to see the docs and unit tests explicitly testing this new functionality implemented. I'm keen to test this out internally |
|
Agreed! I'll add new tests in the next day or two. So far I've just patched the existing tests with new changes implemented :) |
|
@awprice I believe we have the logic covered by unit tests and I've added a cheeky docs update :) Please let me know what you think! Thanks |
|
@awprice Amazing, thank you! |
|
@jackcasey-visier If you're keen on using your change before we've cut a release, you can grab the latest build of master, including your change here - https://github.com/atlassian/escalator/pkgs/container/escalator/280253350?tag=650dda7 |
|
Cheers, thanks again @awprice! Come have a 🍻 if you're ever in Vancouver, BC :) |
closes #245
Summary
This PR is a WIP, TODOs:
Opening in progress to ensure maintainers are happy with the direction and patterns implemented #201
These changes implement a new taint:
atlassian.com/escalator-forceNodes marked with this taint will be removed as soon as all non daemonset pods are completed. This is checked during the Escalator loop
In the current design, this taint is not expected to be added by Escalator to any nodes. The expected usage is for an external system or administrator to implement the taint, and have Escalator perform the safe scale down.
Thank you!