Allow drag for elements with contenteditable="plaintext-only"
#2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hooray! All contributors have signed the CLA. |
smbkr
force-pushed
the
contenteditable-plaintext-only
branch
from
24ed62d to
fa3d70b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the
isAnInteractiveElementfunction to include elements withcontenteditable="plaintext-only"which is defined in the spec and supported by all browsers except Firefox (where support is planned).It simply adds another condition to the existing check.
I've not added an additional test, as the existing tests in
test/unit/integration/drag-handle/shared-behaviours/contenteditable.spec.jsonly check elements defined as<div contenteditable />and not<div contenteditable="true" />, so I wasn't sure if the project aims to cover each and every variant. If additional tests are desired please let me know.