Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added changes on footer #117

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Added changes on footer #117

merged 1 commit into from
Jul 22, 2024

Conversation

13XAVI
Copy link
Contributor

@13XAVI 13XAVI commented Jul 22, 2024

What does this PR do?

  • This PR implements the product details page

Description of the tasks to be completed

  • Added Dinamyte icon
  • Smooth scoll to the top on Dynamite Title
  • Link all subtitle with matching Routes

How can this be manually tested?

  • Navigate to the Footer Page

Related Features

#29

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for dynamite-frontend ready!

Name Link
🔨 Latest commit 1644156
🔍 Latest deploy log https://app.netlify.com/sites/dynamite-frontend/deploys/669e48c53bfe650008d413a9
😎 Deploy Preview https://deploy-preview-117--dynamite-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 92.53731% with 5 lines in your changes missing coverage. Please review.

Project coverage is 76.48%. Comparing base (dfea9f2) to head (1644156).

Files Patch % Lines
src/components/Footer/Footer.tsx 92.53% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #117      +/-   ##
===========================================
+ Coverage    76.46%   76.48%   +0.02%     
===========================================
  Files           91       91              
  Lines        10057    10087      +30     
  Branches       621      621              
===========================================
+ Hits          7690     7715      +25     
- Misses        2364     2369       +5     
  Partials         3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@13XAVI 13XAVI self-assigned this Jul 22, 2024
@13XAVI 13XAVI added bug Something isn't working Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager labels Jul 22, 2024
Copy link
Collaborator

@ambroisegithub ambroisegithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks super for merge!!!

@13XAVI 13XAVI requested a review from niyibi250 July 22, 2024 12:00
@dushimeemma dushimeemma merged commit e05029e into develop Jul 22, 2024
6 checks passed
niyibi250 pushed a commit that referenced this pull request Jul 22, 2024
Added changes on footer (#117)

fix link to product details

fix link to product details

fix link to product details

fix link to product details
niyibi250 pushed a commit that referenced this pull request Jul 22, 2024
added Seller Dashboard (#110)

implement stage 1 design of otp form (#58) (#94) (#106)

rebase from dev and fix eslint errors

implement nextSibling functiion

implement previousSibling while you delete

rebase from develop

resolve deployment errors

implement 2fa functionality

working on verify otp codes and redirect

rebasing from develop

resolve vendor token must be string

implement 2fa verfication

users can now signup with facebook (#74)

side bar implementation (#75)

implement stage 1 design of otp form (#58) (#61)

rebase from dev and fix eslint errors

implement nextSibling functiion

implement previousSibling while you delete

rebase from develop

resolve deployment errors

implement 2fa functionality

working on verify otp codes and redirect

rebasing from develop

resolve vendor token must be string

implement 2fa verfication

Co-authored-by: Rurangwa Leo <[email protected]>

implementation of dashboard nav bar (#79)

added Admin Dashboard Home (#85)

fix bannerSection (#87)

feat(dashboard-metrics): implement visitor insights chart and top categories (#84)

- implement visitor insights chart
- implement top categories section

[Delivers #73]

Fix image and routing (#92)

fix lint error

finall fix lint

finall fix lint

show message when product deleted

fix the commit

fix console lint error

Fix image and routing (#92)

finall fix lint

show message when product deleted

fix the commit

fix console lint error

fix the store

fix the husky

add created at column

Co-authored-by: Rurangwa Leo <[email protected]>

vendor should add product (#67)

Co-authored-by: Pray Eddy SHIMWA <[email protected]>

feat(product-details-page): implement product details page (#108)

- implement product details ui components
-write appropriate tests

[Delivers #101]

Co-authored-by: AMBROISE Muhayimana <[email protected]>

implemented add to cart and cart (#112)

added Seller Dashboard (#110)

feat(wishlist): implement buyer wishlist (#100)

- implement wishlist UI components

[Delivers #96]

implement stage 1 design of otp form (#58) (#61) (#88)

working on orders page

rebase from dev and fix eslint errors

implement nextSibling functiion

implement previousSibling while you delete

rebase from develop

resolve deployment errors

implement 2fa functionality

working on verify otp codes and redirect

rebasing from develop

resolve vendor token must be string

implement 2fa verfication

Co-authored-by: Rurangwa Leo <[email protected]>

fix the image on popular section on langing page

fix the image on popular section on langing page

add exclude for caverage

feat(wishlist): implement buyer wishlist (#100)

- implement wishlist UI components

[Delivers #96]

implement stage 1 design of otp form (#58) (#61) (#88)

working on orders page

rebase from dev and fix eslint errors

implement nextSibling functiion

implement previousSibling while you delete

rebase from develop

resolve deployment errors

implement 2fa functionality

working on verify otp codes and redirect

rebasing from develop

resolve vendor token must be string

implement 2fa verfication

Co-authored-by: Rurangwa Leo <[email protected]>

fix the image on popular section on langing page

fix the image on popular section on langing page

add exclude for caverage

fix the add new product button

fix the add new product button

 add the best selling products table in admin dashboard (#107)

Added changes on footer (#117)

fix link to product details

fix link to product details

fix link to product details

fix link to product details

 add the best selling products table in admin dashboard (#107)

Added changes on footer (#117)

fix link to product details

fix link to product details

fix link to product details

fix link to product details
dushimeemma pushed a commit that referenced this pull request Jul 22, 2024
added Seller Dashboard (#110)

implement stage 1 design of otp form (#58) (#94) (#106)

rebase from dev and fix eslint errors

implement nextSibling functiion

implement previousSibling while you delete

rebase from develop

resolve deployment errors

implement 2fa functionality

working on verify otp codes and redirect

rebasing from develop

resolve vendor token must be string

implement 2fa verfication

users can now signup with facebook (#74)

side bar implementation (#75)

implement stage 1 design of otp form (#58) (#61)

rebase from dev and fix eslint errors

implement nextSibling functiion

implement previousSibling while you delete

rebase from develop

resolve deployment errors

implement 2fa functionality

working on verify otp codes and redirect

rebasing from develop

resolve vendor token must be string

implement 2fa verfication

Co-authored-by: Rurangwa Leo <[email protected]>

implementation of dashboard nav bar (#79)

added Admin Dashboard Home (#85)

fix bannerSection (#87)

feat(dashboard-metrics): implement visitor insights chart and top categories (#84)

- implement visitor insights chart
- implement top categories section

[Delivers #73]

Fix image and routing (#92)

fix lint error

finall fix lint

finall fix lint

show message when product deleted

fix the commit

fix console lint error

Fix image and routing (#92)

finall fix lint

show message when product deleted

fix the commit

fix console lint error

fix the store

fix the husky

add created at column

Co-authored-by: Rurangwa Leo <[email protected]>

vendor should add product (#67)

Co-authored-by: Pray Eddy SHIMWA <[email protected]>

feat(product-details-page): implement product details page (#108)

- implement product details ui components
-write appropriate tests

[Delivers #101]

Co-authored-by: AMBROISE Muhayimana <[email protected]>

implemented add to cart and cart (#112)

added Seller Dashboard (#110)

feat(wishlist): implement buyer wishlist (#100)

- implement wishlist UI components

[Delivers #96]

implement stage 1 design of otp form (#58) (#61) (#88)

working on orders page

rebase from dev and fix eslint errors

implement nextSibling functiion

implement previousSibling while you delete

rebase from develop

resolve deployment errors

implement 2fa functionality

working on verify otp codes and redirect

rebasing from develop

resolve vendor token must be string

implement 2fa verfication

Co-authored-by: Rurangwa Leo <[email protected]>

fix the image on popular section on langing page

fix the image on popular section on langing page

add exclude for caverage

feat(wishlist): implement buyer wishlist (#100)

- implement wishlist UI components

[Delivers #96]

implement stage 1 design of otp form (#58) (#61) (#88)

working on orders page

rebase from dev and fix eslint errors

implement nextSibling functiion

implement previousSibling while you delete

rebase from develop

resolve deployment errors

implement 2fa functionality

working on verify otp codes and redirect

rebasing from develop

resolve vendor token must be string

implement 2fa verfication

Co-authored-by: Rurangwa Leo <[email protected]>

fix the image on popular section on langing page

fix the image on popular section on langing page

add exclude for caverage

fix the add new product button

fix the add new product button

 add the best selling products table in admin dashboard (#107)

Added changes on footer (#117)

fix link to product details

fix link to product details

fix link to product details

fix link to product details

 add the best selling products table in admin dashboard (#107)

Added changes on footer (#117)

fix link to product details

fix link to product details

fix link to product details

fix link to product details

Co-authored-by: NIYOMUGABO BERNARD <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ready for TTL Review the PR is ready to be reviewed by the TTL/Manager
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants