Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Increase test coverage #132

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Conversation

jkarenzi
Copy link
Collaborator

What does this PR do?

  • This PR increases code coverage

Description of the task to be completed

  • Add more tests to cover uncovered lines

How can this be manually tested?

  • By running npm run test:ci and inspecting the project coverage

What are the relevant pivotal trackers?

@jkarenzi jkarenzi added the WIP label Jul 25, 2024
Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for dynamite-frontend ready!

Name Link
🔨 Latest commit 39c4383
🔍 Latest deploy log https://app.netlify.com/sites/dynamite-frontend/deploys/66a39ad272f2a80008f4ec34
😎 Deploy Preview https://deploy-preview-132--dynamite-frontend.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jkarenzi jkarenzi force-pushed the fix-increase-covrage-#124 branch 2 times, most recently from 013fb04 to 2a888fb Compare July 25, 2024 10:40
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 44.68085% with 26 lines in your changes missing coverage. Please review.

Project coverage is 85.91%. Comparing base (c75ab18) to head (fc490ec).
Report is 1 commits behind head on develop.

Files Patch % Lines
src/features/Orders/ordersSlice.ts 3.84% 25 Missing ⚠️
src/components/salesMap/SalesMap.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #132       +/-   ##
============================================
+ Coverage    75.32%   85.91%   +10.59%     
============================================
  Files          108      101        -7     
  Lines        12514    11780      -734     
  Branches       789      827       +38     
============================================
+ Hits          9426    10121      +695     
+ Misses        3086     1657     -1429     
  Partials         2        2               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkarenzi jkarenzi requested review from niyobern, wayneleon1, dushimeemma, 13XAVI and ambroisegithub and removed request for niyobern and wayneleon1 July 26, 2024 12:22
@jkarenzi jkarenzi self-assigned this Jul 26, 2024
@jkarenzi jkarenzi linked an issue Jul 26, 2024 that may be closed by this pull request
@jkarenzi jkarenzi added ready for review The PR is ready for review to be mergrd and removed WIP labels Jul 26, 2024
- add more tests to cover uncovered lines

[#Fixes #124]
@dushimeemma dushimeemma merged commit 362caba into develop Jul 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The PR is ready for review to be mergrd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Increase test coverage
5 participants