-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Increase test coverage #132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dynamite-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jkarenzi
force-pushed
the
fix-increase-covrage-#124
branch
2 times, most recently
from
July 25, 2024 10:40
013fb04
to
2a888fb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #132 +/- ##
============================================
+ Coverage 75.32% 85.91% +10.59%
============================================
Files 108 101 -7
Lines 12514 11780 -734
Branches 789 827 +38
============================================
+ Hits 9426 10121 +695
+ Misses 3086 1657 -1429
Partials 2 2 ☔ View full report in Codecov by Sentry. |
jkarenzi
force-pushed
the
fix-increase-covrage-#124
branch
from
July 26, 2024 12:18
2a888fb
to
fc490ec
Compare
jkarenzi
requested review from
niyobern,
wayneleon1,
dushimeemma,
13XAVI and
ambroisegithub
and removed request for
niyobern and
wayneleon1
July 26, 2024 12:22
jkarenzi
added
ready for review
The PR is ready for review to be mergrd
and removed
WIP
labels
Jul 26, 2024
EddyShimwa
approved these changes
Jul 26, 2024
13XAVI
approved these changes
Jul 26, 2024
- add more tests to cover uncovered lines [#Fixes #124]
jkarenzi
force-pushed
the
fix-increase-covrage-#124
branch
from
July 26, 2024 12:47
fc490ec
to
39c4383
Compare
dushimeemma
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of the task to be completed
How can this be manually tested?
What are the relevant pivotal trackers?