Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

landing page banner section #39

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

Dawaic6
Copy link
Contributor

@Dawaic6 Dawaic6 commented Jun 21, 2024

What does this PR do?

  • This PR implements UI the banner section of the landing page using React, Redux, and Tailwind CSS. The banner section will consist of two advertisements images of products in database as we wish to to add to ads.

Key Changes:

  • Components:

    • BAnnerAds Card: Displays individual product information ( name , short discription,image).
  • Redux Integration:

    • image is fetched using redux from database
  • Styling:

    • TailwindCSS classes applied for visual consistency with the provided design.
    • Responsive design ensures a seamless experience across devices.
  • Testing:

    • Thorough component testing to verify rendering and data flow.

Screenshots:

Tests Screenshot
image
UI on Mobile
image
**UI on Tablet
image

UI on Desktop
image

How to Review:

  1. Checkout this branch and run the application.
  2. Verify that the landing page matches the provided design.
  3. Test product display on different screen sizes (responsiveness).
  4. Check that product data is fetched correctly from the Redux store.
  5. Review code for clarity, best practices, and adherence to project guidelines.

Description of the task to be completed?

  • Implementthe banner section of the landing page
  • Write appropriate tests
  • Components integrated with Redux.
  • Responsive UI matching the design for both desktop and mobile screens.

Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dynamites-ecomm-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 4:00pm

@Dawaic6 Dawaic6 self-assigned this Jun 21, 2024
@Dawaic6 Dawaic6 force-pushed the ft-landing_page_banner_section-#31 branch from 6c6af77 to 411caef Compare June 21, 2024 15:29
@Dawaic6 Dawaic6 force-pushed the ft-landing_page_banner_section-#31 branch from 411caef to 74b36f5 Compare June 21, 2024 15:33
@Dawaic6 Dawaic6 force-pushed the ft-landing_page_banner_section-#31 branch from 74b36f5 to 9e84ed5 Compare June 21, 2024 15:34
@Dawaic6 Dawaic6 force-pushed the ft-landing_page_banner_section-#31 branch from 9e84ed5 to 92e424e Compare June 24, 2024 09:06
@Dawaic6 Dawaic6 force-pushed the ft-landing_page_banner_section-#31 branch from bb8e47d to b074bfe Compare June 25, 2024 12:51
@Dawaic6 Dawaic6 force-pushed the ft-landing_page_banner_section-#31 branch from b074bfe to e0f7d48 Compare June 25, 2024 12:56
@Dawaic6 Dawaic6 force-pushed the ft-landing_page_banner_section-#31 branch from e0f7d48 to e8feedb Compare June 25, 2024 12:59
@Dawaic6 Dawaic6 force-pushed the ft-landing_page_banner_section-#31 branch from 715552a to d41c054 Compare June 25, 2024 13:11
@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 69.46565% with 40 lines in your changes missing coverage. Please review.

Project coverage is 88.37%. Comparing base (71059dc) to head (1bb1538).

Files Patch % Lines
src/components/bannerAds/bannerSection.tsx 26.66% 22 Missing ⚠️
src/app/bannerAds/BannerSlice.tsx 80.39% 10 Missing ⚠️
src/pages/Home.tsx 14.28% 6 Missing ⚠️
tailwind.config.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #39      +/-   ##
===========================================
- Coverage    89.54%   88.37%   -1.17%     
===========================================
  Files           29       32       +3     
  Lines         1980     2108     +128     
  Branches       136      141       +5     
===========================================
+ Hits          1773     1863      +90     
- Misses         203      241      +38     
  Partials         4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for dynamites-ecomm-fe ready!

Name Link
🔨 Latest commit 1bb1538
🔍 Latest deploy log https://app.netlify.com/sites/dynamites-ecomm-fe/deploys/667ede21d1dc700007e93ceb
😎 Deploy Preview https://deploy-preview-39--dynamites-ecomm-fe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@ambroisegithub ambroisegithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for merge!!!

Copy link
Contributor

@EddyShimwa EddyShimwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

-implement reusable navbar component

[Delivers #21]
@Dawaic6 Dawaic6 force-pushed the ft-landing_page_banner_section-#31 branch from 8cbf4fb to 1bb1538 Compare June 28, 2024 16:00
@dushimeemma dushimeemma merged commit 5d62524 into develop Jun 29, 2024
8 checks passed
niyibi250 pushed a commit that referenced this pull request Jul 2, 2024
-implement reusable navbar component

[Delivers #21]

Hello section (#47)

[Delivers #21]

Co-authored-by: Joslyn Manzi Karenzi <[email protected]>

implementation of signup page and functionality (#50)

setup envirnoment (#24)

implement HSButton

implement HSInput

mend

implement login design

resolve eslint errors

rebase from develop

fix hovering styles  button

rebase form develop

set up formik

implement stage 1 of valifation usin formik

Reducing boilerplate

reduce duplicate codes

rebase from develop

complete form validatio

remove eslint error & initials unit tests

abort all written tests

working on lints

update eslint file

fix test errors

rebase from develop

implement Login component

resolve mismatch uri

28 implement UI for landing page categories section (#48)

* created categories section

Hello section (#47)

[Delivers #21]

Co-authored-by: Joslyn Manzi Karenzi <[email protected]>

created categories section

feat: update search button background color in CategoriesSection

chore: update npm dependencies

feat: Add lazy loading for images in product list

- Implement lazy loading for images in the product list to improve page load performance
- Update ProductSlice.ts to fetch product data from the API
- Update productList.tsx to display only the first 3 products
- Update Category.tsx to add cursor pointer to category component
- Update productCard.test.tsx to fix the calculation of star icons
- Update categories.tsx to style the search input and search button

feat: Implement lazy loading for images in product list

removed console.log

adding dynamism in categories

created categories section

chore: update npm dependencies

feat: Add lazy loading for images in product list

- Implement lazy loading for images in the product list to improve page load performance
- Update ProductSlice.ts to fetch product data from the API
- Update productList.tsx to display only the first 3 products
- Update Category.tsx to add cursor pointer to category component
- Update productCard.test.tsx to fix the calculation of star icons
- Update categories.tsx to style the search input and search button

feat: Implement lazy loading for images in product list

removed console.log

created categories section

done

feat: Update CategoriesSection to fetch products and categories on component mount

- Add useEffect hook to CategoriesSection component to fetch products and categories on component mount
- Update categories.tsx to import fetchProducts and fetchCategories from ProductSlice and categorySlice respectively
- Remove duplicate import statement for useAppSelector from '@/app/hooks'

feat: Add MemoryRouter to App.test.tsx for testing Home component

- Import MemoryRouter from 'react-router-dom' to wrap the Home component in the App.test.tsx file
- This allows testing the Home component within the context of a router

* finished

feat(navbar): implement navbar (#44) (#39)

-implement reusable navbar component

[Delivers #21]

Co-authored-by: Joslyn Manzi Karenzi <[email protected]>

fix(navbar): fix bug in navbar (#54)

- make sure that navbar shows login button when user is not authenticated

[Fixes #53]

fix(frontend): write  test for the availableproduct slice

fix(frontend): write  test for the availableproduct slice

fix testing

fix remaining test

fix lint errors

build  errors

build  errors

build  errors
EddyShimwa pushed a commit that referenced this pull request Jul 3, 2024
-implement reusable navbar component

[Delivers #21]

Co-authored-by: Joslyn Manzi Karenzi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Front-End ready for review The PR is ready for review to be mergrd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants