-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Display Products in the Dashboard #77
Closed
niyibi250
wants to merge
6
commits into
develop
from
68-implementing-DisplayProducts-in-the-dashboard
Closed
Implementing Display Products in the Dashboard #77
niyibi250
wants to merge
6
commits into
develop
from
68-implementing-DisplayProducts-in-the-dashboard
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebase from dev and fix eslint errors implement nextSibling functiion implement previousSibling while you delete rebase from develop resolve deployment errors implement 2fa functionality working on verify otp codes and redirect rebasing from develop resolve vendor token must be string implement 2fa verfication fix index error fix loading same routes error fix loading same routes error write tests write tests
rebase from dev and fix eslint errors implement nextSibling functiion implement previousSibling while you delete rebase from develop resolve deployment errors implement 2fa functionality working on verify otp codes and redirect rebasing from develop resolve vendor token must be string implement 2fa verfication fix index error fix loading same routes error fix loading same routes error write tests write tests
…tps://github.com/atlp-rwanda/dynamites-ecomm-fe into 68-implementing-DisplayProducts-in-the-dashboard
✅ Deploy Preview for dynamite-frontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #77 +/- ##
===========================================
- Coverage 88.33% 82.98% -5.35%
===========================================
Files 44 48 +4
Lines 3224 3733 +509
Branches 223 239 +16
===========================================
+ Hits 2848 3098 +250
- Misses 372 631 +259
Partials 4 4 ☔ View full report in Codecov by Sentry. |
niyibi250
requested review from
dushimeemma,
wayneleon1,
bertrandshema,
ambroisegithub and
13XAVI
July 9, 2024 11:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implement product display components, integrate with Redux for state management, add pagination controls, and write unit tests for product management in the vendor dashboard.
Description of Task to be completed?
As a vendor, this PR aims to display a list of products in the dashboard, fetch product data from the backend API, integrate state management with Redux Toolkit, implement pagination controls, and ensure robust unit test coverage.
How should this be manually tested?
- Fetch and Display Products:
- Pagination Controls:
Test pagination functionality to navigate through the product list.
Confirm correct display of pagination state.
- State Management:
- Unit Tests:
Any background context you want to provide?
This PR is part of enhancing vendor dashboard functionality to improve inventory management by providing a clear view of product listings with robust state management and testing.
What are the relevant pivotal tracker/Trello stories?
#78 (comment)
#65 (comment)
Screenshots (if appropriate)
Questions:
Any feedback or suggestions on the implementation approach are welcome!