Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Display Products in the Dashboard #80

Closed

Conversation

niyibi250
Copy link
Contributor

What does this PR do?

Implement product display components, integrate with Redux for state management, add pagination controls, and write unit tests for product management in the vendor dashboard.

Description of Task to be completed?

As a vendor, this PR aims to display a list of products in the dashboard, fetch product data from the backend API, integrate state management with Redux Toolkit, implement pagination controls, and ensure robust unit test coverage.

How should this be manually tested?

- Fetch and Display Products:

  • Ensure products are fetched and displayed in a table/grid format.
  • Verify the layout and responsiveness using TailwindCSS.

- Pagination Controls:

Test pagination functionality to navigate through the product list.
Confirm correct display of pagination state.

- State Management:

  • Check loading indicators during data fetch.
  • Validate error handling if data fetch fails.

- Unit Tests:

  • Run Jest/Testing Library tests to verify data fetching, state management, and component functionality.
  • Mock API responses and Redux actions to simulate different scenarios.

Any background context you want to provide?

This PR is part of enhancing vendor dashboard functionality to improve inventory management by providing a clear view of product listings with robust state management and testing.

What are the relevant pivotal tracker/Trello stories?

#78 (comment)

#65 (comment)

Screenshots (if appropriate)

Screenshot 2024-07-09 134713

Screenshot 2024-07-09 164348

Questions:

Any feedback or suggestions on the implementation approach are welcome!

Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for dynamite-frontend failed.

Name Link
🔨 Latest commit c86a6e9
🔍 Latest deploy log https://app.netlify.com/sites/dynamite-frontend/deploys/66963dd02b1cfc0008f98c32

@niyibi250 niyibi250 force-pushed the 68-implementing-Display-Products-in-the-dashboard branch from 0305db5 to 75d9ce6 Compare July 9, 2024 14:53
@niyibi250 niyibi250 self-assigned this Jul 9, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 49.06716% with 273 lines in your changes missing coverage. Please review.

Project coverage is 83.04%. Comparing base (4b8c675) to head (75d9ce6).

Files Patch % Lines
src/components/dashBoard/Table.tsx 11.38% 249 Missing ⚠️
src/features/Dashboard/dashboardProductsSlice.ts 83.67% 8 Missing ⚠️
src/layout/DashbordLayout.tsx 0.00% 8 Missing ⚠️
src/pages/DesplayProductPage.tsx 36.36% 7 Missing ⚠️
tailwind.config.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #80      +/-   ##
===========================================
- Coverage    88.52%   83.04%   -5.48%     
===========================================
  Files           46       51       +5     
  Lines         3424     3951     +527     
  Branches       242      255      +13     
===========================================
+ Hits          3031     3281     +250     
- Misses         389      666     +277     
  Partials         4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niyibi250 niyibi250 added Front-End ready for review The PR is ready for review to be mergrd labels Jul 9, 2024
niyobern and others added 2 commits July 10, 2024 10:29
rebase from dev and fix eslint errors

implement nextSibling functiion

implement previousSibling while you delete

rebase from develop

resolve deployment errors

implement 2fa functionality

working on verify otp codes and redirect

rebasing from develop

resolve vendor token must be string

implement 2fa verfication

Co-authored-by: Rurangwa Leo <[email protected]>
@niyibi250 niyibi250 added WIP and removed ready for review The PR is ready for review to be mergrd labels Jul 10, 2024
@niyibi250 niyibi250 closed this Jul 18, 2024
@niyibi250 niyibi250 deleted the 68-implementing-Display-Products-in-the-dashboard branch July 18, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants