Merge pull request #258 from atom-community/make-autocomplete-heigher…

…-zindex-than-linter Ensure that css can modify z-index, and put autocomplete at a slightly h...
atom · Feb 11, 2015 · 49b5215 · 49b5215 · basarat · Feb 11, 2015
2 parents 4cf7dca + 6e20a2e
commit 49b5215
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/suggestion-list-element.coffee b/lib/suggestion-list-element.coffee
@@ -6,11 +6,13 @@ class SuggestionListElement extends HTMLElement
 
   createdCallback: ->
     @subscriptions = new CompositeDisposable
-    @classList.add('popover-list', 'select-list', 'autocomplete-plus', 'autocomplete-suggestion-list')
+    @classList.add('popover-list', 'select-list', 'autocomplete-suggestion-list')
     @subscriptions.add(atom.config.observe('autocomplete-plus.maxSuggestions', => @maxItems = atom.config.get('autocomplete-plus.maxSuggestions')))
     @registerMouseHandling()
 
   attachedCallback: ->
+    # TODO: Fix overlay decorator to in atom to apply class attribute correctly, then move this to overlay creation point.
+    @parentElement.classList.add('autocomplete-plus')
     @addActiveClassToEditor()
     @renderList() unless @ol
     @itemsChanged()

diff --git a/styles/autocomplete.less b/styles/autocomplete.less
@@ -1,5 +1,7 @@
 @import "ui-variables";
-
+atom-overlay.autocomplete-plus {
+    z-index: 5;
+}
 autocomplete-suggestion-list.select-list.popover-list {
   width: auto;
   display: inline-block;