Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Improve status-bar overlapping #62

Merged
merged 1 commit into from
Apr 7, 2015
Merged

Improve status-bar overlapping #62

merged 1 commit into from
Apr 7, 2015

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Mar 6, 2015

Problem:

The left and right sides of the status-bar can overlap when the window gets narrow.

screen shot 2015-03-07 at 12 07 53 am

This PR:

  • adds a max-width to any .inline-blocks. Like when there is a huge branch name.

screen shot 2015-03-07 at 12 09 41 am

  • prioritizes right side with 2/3 of the space
  • left side with 1/3 -> will get cut-off first
  • adds overflow scrolling

status-bar

Fixes #48, #38 and maybe also #53.

Questions:

  1. There was a flexbox hack added: b953bc3 Not sure if adding a flexbox inside has a negative effect
  2. The .cursor-position ( e.g. 9/25 after the file path) gets cut off first, maybe it could be moved to the far left, before the file path?

- adds a max-width to any .inline-block
-adds overflow scrolling
- priotizes right side with 2/3 of the space
- left side with 1/3 -> will get cut-off first
@thomasjo
Copy link

thomasjo commented Mar 6, 2015

👍

One little thought though, how about adding a tooltip to the text elements instead of scrolling? Scrolling stuff in a status bar feels a little bit weird. Otherwise, perhaps a "scrolling" animation on a 500 ms activation timeout or some such.

@simurai
Copy link
Contributor Author

simurai commented Mar 6, 2015

Adding a tooltip could be an option, it also got mentioned in #53.

Yeah, I agree that scrolling in the status bar is a bit odd, but it's more a measure of last resort. Because even with tooltips, there is still a chance of items getting cut off. So in emergency you can still scroll rather than not be able to see some items at all.

Another option would be to have some sort of "more" popup. Something like [Item Item Item ... ], then when clicking on "..." a popup appears with the rest. But maybe that's for another PR.

@thomasjo
Copy link

thomasjo commented Mar 6, 2015

Another option would be to have some sort of "more" popup. Something like [Item Item Item ... ], then with clicking on "..." a popup appears with the rest. But maybe that's for another PR.

I think I like this concept. Best of both worlds in a sense. And I agree it might be best to experiment with that in a separate PR, since this PR improves the current state and looks good to me.

@benogle
Copy link
Contributor

benogle commented Apr 6, 2015

:shipit: no?

@simurai
Copy link
Contributor Author

simurai commented Apr 7, 2015

Yep! Could still be improved, but at least looks less broken.

simurai added a commit that referenced this pull request Apr 7, 2015
Improve status-bar overlapping
@simurai simurai merged commit 4537c24 into master Apr 7, 2015
@simurai simurai deleted the sm-fix-overlap branch April 7, 2015 03:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long strings in statusbar overlap
3 participants