no need for a pointer to an interface

atomist-skills · Sep 5, 2024 · 0bc04a6 · 0bc04a6
1 parent f12f479
commit 0bc04a6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/policy/data/fixed.go b/policy/data/fixed.go
@@ -13,11 +13,11 @@ type vulnerabilityFetcher func(ctx context.Context, evalCtx goals.GoalEvaluation
 
 type fixedDataSource struct {
 	jynxGQLClient   query.QueryClient
-	proxyClient     *proxy.ProxyClient
+	proxyClient     proxy.ProxyClient
 	vulnerabilities vulnerabilityFetcher
 }
 
-func NewFixedDataSource(jynxGQLClient query.QueryClient, proxyClient *proxy.ProxyClient, vulnerabilities vulnerabilityFetcher) DataSource {
+func NewFixedDataSource(jynxGQLClient query.QueryClient, proxyClient proxy.ProxyClient, vulnerabilities vulnerabilityFetcher) DataSource {
 	return &fixedDataSource{
 		jynxGQLClient:   jynxGQLClient,
 		proxyClient:     proxyClient,
@@ -29,7 +29,7 @@ func (ds *fixedDataSource) GetQueryClient() query.QueryClient {
 	return ds.jynxGQLClient
 }
 
-func (ds *fixedDataSource) GetProxyClient() (*proxy.ProxyClient, error) {
+func (ds *fixedDataSource) GetProxyClient() (proxy.ProxyClient, error) {
 	return ds.proxyClient, nil
 }
 

diff --git a/policy/data/source.go b/policy/data/source.go
@@ -11,7 +11,7 @@ import (
 
 type DataSource interface {
 	GetQueryClient() query.QueryClient
-	GetProxyClient() (*proxy.ProxyClient, error)
+	GetProxyClient() (proxy.ProxyClient, error)
 
 	GetImageVulnerabilities(ctx context.Context, evalCtx goals.GoalEvaluationContext, imageSbom types.SBOM) (*query.QueryResponse, []types.Package, map[string][]types.Vulnerability, error)
 }