Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base the image on alpine 3.18 with node v18 #87

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Base the image on alpine 3.18 with node v18 #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7240cb9
Base the image on alpine 3.18 with node v18
velll Nov 17, 2023
114f7b3
Skip `load` option for `build-and-push`
velll Nov 17, 2023
86cf4c6
digest
velll Nov 17, 2023
61f2662
Include 3.18 instead of `edge` in the image tag
velll Nov 17, 2023
0ce4424
Pin correct index digest
velll Nov 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/docker-publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
with:
images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
tags: |
type=raw,value=alpine_edge-node_18
type=raw,value=alpine_3.18-node_18
labels: |
org.opencontainers.image.revision=${{ env.SHA }}

Expand All @@ -79,7 +79,5 @@ jobs:
platforms: "linux/amd64,linux/arm64"
context: .
push: ${{ github.event_name != 'pull_request' }}
load: ${{ github.event_name == 'pull_request' }}
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}

6 changes: 3 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM alpine:3.14@sha256:eb3e4e175ba6d212ba1d6e04fc0782916c08e1c9d7b45892e9796141b1d379ae
FROM alpine:3.18@sha256:eece025e432126ce23f223450a0326fbebde39cdf496a85d8c016293fc851978

LABEL maintainer="Atomist <[email protected]>"

Expand All @@ -9,11 +9,11 @@ RUN apk add --no-cache \

# Install Node.js
RUN apk add --no-cache \
nodejs=18.18.0-r0
nodejs=18.18.2-r0

# Install Git
RUN apk add --no-cache \
git=2.42.0-r0
git=2.40.1-r0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to downgrade git moving down from edge to 3.18:

3.18: https://pkgs.alpinelinux.org/packages?name=git&branch=v3.18&repo=&arch=&maintainer=
edge: https://pkgs.alpinelinux.org/packages?name=git&branch=edge&repo=&arch=&maintainer=

# ENV VARs needed for Node.js
ENV BLUEBIRD_WARNINGS=0 \
Expand Down
Loading