-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make build-ledger, fix reproducible builds, reinforce go version #24
Conversation
Require precisely go1.21.13 to enable reproducible builds with CI. Store version 1.21.13 in Makefile and make it available for CI.
6ca58f7
to
74a6299
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are enforcing even the subversion while technically that would not be needed if not for consistency of hashes for reproducible builds.
I am not against it, but it's a little tighter as a requirement than what we actually need.
True, but I have found this to be the easiest way to ensure reproducible builds for most users. If we remove the subversion check, and just check the major version, how do we know about reproducible builds? We could print a warning, but that would be a 4 line warning with all the instructions, it looks a bit annoying to have that for every build, so I chose the current solution. Let me know if you think of another way. |
@giunatale see d13bc86 |
make print_required_go_version
so CI can fetch the information