Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make build-ledger, fix reproducible builds, reinforce go version #24

Merged
merged 13 commits into from
Sep 25, 2024

Conversation

tbruyelle
Copy link
Collaborator

@tbruyelle tbruyelle commented Sep 23, 2024

  • add make build-ledger
  • fix CI env set TM_VERSION
  • reinforce go version to go1.21.13
    • build will exit if go version doesn't match exactly
    • print instruction to run with specific go version
    • add make print_required_go_version so CI can fetch the information

@tbruyelle tbruyelle changed the title chore: make build-ledger chore: make build-ledger, fix reproducible builds Sep 24, 2024
@tbruyelle tbruyelle marked this pull request as ready for review September 24, 2024 09:56
Require precisely go1.21.13 to enable reproducible builds with CI.
Store version 1.21.13 in Makefile and make it available for CI.
@tbruyelle tbruyelle force-pushed the tbruyelle/chore/make-build-ledger branch from 6ca58f7 to 74a6299 Compare September 24, 2024 15:33
@tbruyelle tbruyelle changed the title chore: make build-ledger, fix reproducible builds chore: make build-ledger, fix reproducible builds, reinforce go version Sep 24, 2024
Copy link
Collaborator

@giunatale giunatale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are enforcing even the subversion while technically that would not be needed if not for consistency of hashes for reproducible builds.

I am not against it, but it's a little tighter as a requirement than what we actually need.

@tbruyelle
Copy link
Collaborator Author

we are enforcing even the subversion while technically that would not be needed if not for consistency of hashes for reproducible builds.

I am not against it, but it's a little tighter as a requirement than what we actually need.

True, but I have found this to be the easiest way to ensure reproducible builds for most users.

If we remove the subversion check, and just check the major version, how do we know about reproducible builds? We could print a warning, but that would be a 4 line warning with all the instructions, it looks a bit annoying to have that for every build, so I chose the current solution.

Let me know if you think of another way.

@tbruyelle
Copy link
Collaborator Author

@giunatale see d13bc86

@tbruyelle tbruyelle merged commit db654c9 into main Sep 25, 2024
12 checks passed
@tbruyelle tbruyelle deleted the tbruyelle/chore/make-build-ledger branch September 25, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants