test: add some tally tests #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbruyelle
requested review from
giunatale,
jaekwon and
adam-hanna
as code owners
tbruyelle
force-pushed
the
tbruyelle/test/tally
branch
from
10e1466
to
829aa8b
Compare
Cherry pick of cosmos/cosmos-sdk#17142
tbruyelle
force-pushed
the
tbruyelle/test/tally
branch
from
829aa8b
to
b7a257f
Compare
adam-hanna
approved these changes
Sep 4, 2024
giunatale
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of cosmos/cosmos-sdk#17142 with some updates that improves the mocking of the staking module.
Mocking this module is deceptively complex, due to the shares system. I would better have integration tests for testing the tally, like
cosmos-sdk/tests/integration/gov, but unfortunately these are difficult to migrate out of the cosmos-sdk (if not impossible).