Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #87

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #87

wants to merge 1 commit into from

Conversation

WaqarMMirza
Copy link
Contributor

Proofreading.

@WaqarMMirza
Update README.md
5a725b0 
Proofreading.
@WaqarMMirza WaqarMMirza requested a review from jaekwon as a code owner December 14, 2023 19:18
giunatale
giunatale approved these changes Dec 16, 2023
View reviewed changes
Copy link
Collaborator

@giunatale giunatale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY!

jaekwon
jaekwon reviewed Dec 17, 2023
View reviewed changes
README.md Show resolved Hide resolved
jaekwon
jaekwon reviewed Dec 17, 2023
View reviewed changes
README.md
Gaia to save Gaia from itself. A modification to the distribution of $ATONE
through slashing those who voted in favor of #848 would help ensure that the
Gaia to save Gaia from itself. A modification to the distribution of $ATONE,
a through slashing of those who voted in favor of #848 would help ensure that the
Copy link
Contributor

@jaekwon jaekwon Dec 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you mean "through a slashing of"? or "such as through a slashing of"?
i still think the previous version makes more sense.
the slashing isn't necessarily singular,
and I think it's better without the comma. if there is a comma there should be a pair.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I meant "through a slashing of".
We can also use a comma after a shorter phrase when we want to emphasize it or add a pause for literary effect.

jaekwon
jaekwon reviewed Dec 17, 2023
View reviewed changes
README.md Show resolved Hide resolved
@WaqarMMirza
Copy link
Contributor Author

@jaekwon should I close the PR if you think the changes are unnecessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaekwon jaekwon jaekwon left review comments

@giunatale giunatale giunatale approved these changes

@moul moul moul approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WaqarMMirza @jaekwon @moul @giunatale