-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update(readme): various enhancements #92
base: main
Are you sure you want to change the base?
Conversation
@moul gentle ping |
> **This document is a work in progress. We encourage you to make pull requests. Currently, our priority is to open issues and initiate discussions about every facet that should be included in the founding documents.** | ||
|
||
<p align="left"> | ||
AtomOne is a strategic fork of the Cosmos Hub. It redefines the Cosmos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"it redefines the cosmos ecosystem as a minimal IBC/ICS Hub." -> not correct/accurate.
|
||
<p align="left"> | ||
AtomOne is a strategic fork of the Cosmos Hub. It redefines the Cosmos | ||
ecosystem as a minimal IBC/ICS Hub. AtomOne is committed to secure, decentralized |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"AtomeOne is committed" -> The project isn't committed by him alone. Perhaps the community or authors are, but not the project itself.
<p align="left"> | ||
AtomOne is a strategic fork of the Cosmos Hub. It redefines the Cosmos | ||
ecosystem as a minimal IBC/ICS Hub. AtomOne is committed to secure, decentralized | ||
decision-making, and focuses on driving innovative advancements within the Cosmos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The focus is not on driving, but on enabling. We prioritize creating a secure minimal hub that unlocks more opportunities for experimentation with fewer risks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request is too large for minimal improvements. Additionally, the changelog is lost because most of the text appears to have been rewritten, possibly by an AI.
I will close it, and you can reopen smaller pull requests if certain parts of this one should be merged.
Context provided here. There are also general grammatical errors addressed beyond {re-}writing the content to add a layer of formality. |
Thanks for the input, @moul.
Above all, the claim on the proposed writing style improvements is misleading, and, like the first point, unsure why we went through three reviews to speculate this.
Contribution split is useful - I believe the diff is not directly available in that section of the README due to content being moved around (such as the terms.)
Points of contention should be clearly pointed out as opposed to speculating. I believe there are also verification methods available. I've provided an example below. If necessary, I can be abundantly clear and provide detailed context for each phrase and statement that was proposed in this PR, and detail the overall relation to AtomOne x Genesis. Keep in mind that I'm providing context to back the efforts of the contributions, having made them in good faith... Example using "Declaration of Genesis"General:
So iterating entirely on the existing content felt appropriate. P1:
P2:
So, I removed the second paragraph due to its perceived redundancy, merging its content with the first and subsequent paragraphs in this section. The first paragraph changed to the following:
P3:
P4:
Changed to:
|
re-opening (but not yet making any determination about whether any splitting is needed; more of a reminder for myself). |
architecture. In terms of governance, AtomOne introduces a higher consensus | ||
threshold (Constitutional Majority) and emphasizes decentralized | ||
decision-making. In terms of software, AtomOne will start as a fork of | ||
"cosmoshub4". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"cosmoshub4". | |
"cosmoshub-4". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also done in other places. But the correct chain ID has a dash
https://github.com/cosmos/chain-registry/blob/master/cosmoshub/chain.json
Iterates on the existing content of the README, focussing on Preamble, Declaration of Genesis, Vision and Missions, and Terms.
If this approach seems okay, we can continue on with the other sections.
Looking forward to your feedback and suggestions.