Skip to content

Commit

Permalink
chore: add build-ledger Makefile target (#52)
Browse files Browse the repository at this point in the history
  • Loading branch information
tbruyelle authored Sep 20, 2024
1 parent 6a83682 commit 5da03f1
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 1 deletion.
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@

### BUG FIXES

* Revert fix duplicate amino path in gov module ([#48](https://github.com/atomone-hub/govgen/pull/48))
* Revert fix duplicate amino path in gov module ([#51](https://github.com/atomone-hub/govgen/pull/51))

### FEATURES

* Add `build-ledger` Makefile target ([#52](https://github.com/atomone-hub/govgen/pull/52))

## v1.0.3

Expand Down
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,10 @@ all: install lint run-tests vulncheck

BUILD_TARGETS := build install

build-ledger: check_version go.sum $(BUILDDIR)/
@echo "WARNING: Ledger build involves enabling cgo, which disables the ability to have reproducible builds."
CGO_ENABLED=1 go build -mod=readonly $(BUILD_FLAGS) $(BUILD_ARGS) -o $(BUILDDIR)/ ./...

build: BUILD_ARGS=-o $(BUILDDIR)/

$(BUILD_TARGETS): check_version go.sum $(BUILDDIR)/
Expand Down
7 changes: 7 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,10 @@ locally as the Github Release section. To do this, checkout to the expected
version and then simply run `make build` (which will output the binary to the
`build` directory) or `make install`. The resulted binary should have the same
sha256 hash than the one from the Github Release section.

## Ledger support

Run `make build-ledger` to have ledger support in `./build/govgend` binary.
Note that this will disable reproducible builds, as it introduces OS
dependencies.

0 comments on commit 5da03f1

Please sign in to comment.