feat(x/gov): remove ability for validators to add votes #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giunatale
force-pushed
the
giunatale/feat/gov-vals-no-voting
branch
from
c46b682
to
335beb8
Compare
giunatale
force-pushed
the
giunatale/feat/gov-vals-no-voting
branch
from
21aefa0
to
335beb8
Compare
tbruyelle
approved these changes
Feb 12, 2024
|
One question before merging, don't you think this should only apply to text proposals? I'm afraid we'll have trouble getting a quorum for param changes and upgrade proposals if validators can't vote with their delegation power. |
tbruyelle
reviewed
Feb 13, 2024
CHANGELOG.md
Outdated
| @@ -12,5 +12,7 @@ | |||
|
|
|||
| ### FEATURES | |||
|
|
|||
| ### STATE BREAKING | |||
| * Forked `x/gov` module from Cosmos SDK v0.46.16 for custom moficiations. | |||
| * Removed ability for validators to vote on proposals. | |||
There was a problem hiding this comment.
We should add a link to the related PR
|
Let's merge for now. I understand what you are saying though. Maybe worth tracking this with an issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #7
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump).changelog(for details, see contributing guidelines)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change