Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix linter #14

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

tbruyelle
Copy link
Collaborator

@tbruyelle tbruyelle commented Feb 13, 2024

  • fix govgen import path in gci tool configuration in the .golangci.yml file
  • fix import order in respect of that configuration (make format can do that automatically)
  • fix usage of //nolint: unparam

Not sure if we should target feat/custom-gov-module or main branch, give me your though!

@giunatale
Copy link
Collaborator

@tbruyelle let's target main, I think it makes sense especially as we are approaching merging also the gov modifications.

Copy link
Collaborator

@giunatale giunatale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either way, main or feature branch, we soon enough will upstream these changes so it doesn't really makes that much diff.

I am thinking main, but tbh it's really the same.

@tbruyelle
Copy link
Collaborator Author

tbruyelle commented Feb 13, 2024

Thinking about it, even if we target main, we still need a linter PR for the feature branch, for the gov module we've added. So let's merge it there.

@giunatale
Copy link
Collaborator

Thinking about it, even if we target main', we still need a linter PR for the feature branch, for the gov' module we've added. So let's merge it there.

makes a lot of sense!
LGTM

@tbruyelle tbruyelle merged commit 86e32fb into feat/custom-gov-module Feb 13, 2024
4 of 7 checks passed
@tbruyelle tbruyelle deleted the tbruyelle/chore/fix-linter branch February 13, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants