Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve vote inheritance testing #23

Merged
merged 2 commits into from
Feb 22, 2024
Merged

test: improve vote inheritance testing #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e257af4
test: re-enable vote inheritance and improve tests
tbruyelle Feb 21, 2024
3696c7c
test: re-disable vote inheritance and update tests
tbruyelle Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 40 additions & 9 deletions x/gov/keeper/tally_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,8 @@ func TestTallyDelgatorInherit(t *testing.T) {
app := govgenhelpers.SetupNoValset(false)
ctx := app.BaseApp.NewContext(false, tmproto.Header{})

addrs, vals := createValidators(t, ctx, app, []int64{5, 6, 7})
valPowers := []int64{5, 6, 7}
addrs, vals := createValidators(t, ctx, app, valPowers)

delTokens := app.StakingKeeper.TokensFromConsensusPower(ctx, 30)
val3, found := app.StakingKeeper.GetValidator(ctx, vals[2])
Expand Down Expand Up @@ -309,14 +310,25 @@ func TestTallyDelgatorInherit(t *testing.T) {

require.False(t, passes)
require.False(t, burnDeposits)
require.False(t, tallyResults.Equals(types.EmptyTallyResult()))
valSelfDelegations := []sdk.Int{
app.StakingKeeper.TokensFromConsensusPower(ctx, valPowers[0]),
app.StakingKeeper.TokensFromConsensusPower(ctx, valPowers[1]),
app.StakingKeeper.TokensFromConsensusPower(ctx, valPowers[2]),
}
require.Equal(t, tallyResults.String(), types.NewTallyResult(
valSelfDelegations[2],
sdk.ZeroInt(),
valSelfDelegations[0].Add(valSelfDelegations[1]),
sdk.ZeroInt(),
).String())
}

func TestTallyDelgatorMultipleOverride(t *testing.T) {
app := govgenhelpers.SetupNoValset(false)
ctx := app.BaseApp.NewContext(false, tmproto.Header{})

addrs, vals := createValidators(t, ctx, app, []int64{5, 6, 7})
valPowers := []int64{5, 6, 7}
addrs, vals := createValidators(t, ctx, app, valPowers)

delTokens := app.StakingKeeper.TokensFromConsensusPower(ctx, 10)
val1, found := app.StakingKeeper.GetValidator(ctx, vals[0])
Expand Down Expand Up @@ -349,7 +361,17 @@ func TestTallyDelgatorMultipleOverride(t *testing.T) {

require.False(t, passes)
require.False(t, burnDeposits)
require.False(t, tallyResults.Equals(types.EmptyTallyResult()))
valSelfDelegations := []sdk.Int{
app.StakingKeeper.TokensFromConsensusPower(ctx, valPowers[0]),
app.StakingKeeper.TokensFromConsensusPower(ctx, valPowers[1]),
app.StakingKeeper.TokensFromConsensusPower(ctx, valPowers[2]),
}
require.Equal(t, tallyResults.String(), types.NewTallyResult(
valSelfDelegations[0].Add(valSelfDelegations[1]).Add(valSelfDelegations[2]),
sdk.ZeroInt(),
delTokens.Add(delTokens),
sdk.ZeroInt(),
).String())
}

// As validators can only vote with their own stake, delegators don't inherit votes from validators
giunatale marked this conversation as resolved.
Show resolved Hide resolved
Expand All @@ -358,9 +380,8 @@ func TestTallyDelgatorMultipleInherit(t *testing.T) {
app := govgenhelpers.SetupNoValset(false)
ctx := app.BaseApp.NewContext(false, tmproto.Header{})

createValidators(t, ctx, app, []int64{25, 6, 7})

addrs, vals := createValidators(t, ctx, app, []int64{5, 6, 7})
valPowers := []int64{5, 6, 7}
addrs, vals := createValidators(t, ctx, app, valPowers)

delTokens := app.StakingKeeper.TokensFromConsensusPower(ctx, 10)
val2, found := app.StakingKeeper.GetValidator(ctx, vals[1])
Expand Down Expand Up @@ -390,9 +411,19 @@ func TestTallyDelgatorMultipleInherit(t *testing.T) {
require.True(t, ok)
passes, burnDeposits, tallyResults := app.GovKeeper.Tally(ctx, proposal)

require.True(t, passes)
require.False(t, passes)
require.False(t, burnDeposits)
require.False(t, tallyResults.Equals(types.EmptyTallyResult()))
valSelfDelegations := []sdk.Int{
app.StakingKeeper.TokensFromConsensusPower(ctx, valPowers[0]),
app.StakingKeeper.TokensFromConsensusPower(ctx, valPowers[1]),
app.StakingKeeper.TokensFromConsensusPower(ctx, valPowers[2]),
}
require.Equal(t, tallyResults.String(), types.NewTallyResult(
valSelfDelegations[0],
sdk.ZeroInt(),
valSelfDelegations[1].Add(valSelfDelegations[2]),
sdk.ZeroInt(),
).String())
}

func TestTallyJailedValidator(t *testing.T) {
Expand Down
Loading