Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add build-ledger Makefile target #52

Merged
merged 1 commit into from
Sep 20, 2024
Merged

chore: add build-ledger Makefile target #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@

### BUG FIXES

* Revert fix duplicate amino path in gov module ([#48](https://github.com/atomone-hub/govgen/pull/48))
* Revert fix duplicate amino path in gov module ([#51](https://github.com/atomone-hub/govgen/pull/51))

### FEATURES

* Add `build-ledger` Makefile target ([#52](https://github.com/atomone-hub/govgen/pull/52))

## v1.0.3

Expand Down
4 changes: 4 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,10 @@ all: install lint run-tests vulncheck

BUILD_TARGETS := build install

build-ledger: check_version go.sum $(BUILDDIR)/
@echo "WARNING: Ledger build involves enabling cgo, which disables the ability to have reproducible builds."
CGO_ENABLED=1 go build -mod=readonly $(BUILD_FLAGS) $(BUILD_ARGS) -o $(BUILDDIR)/ ./...

build: BUILD_ARGS=-o $(BUILDDIR)/

$(BUILD_TARGETS): check_version go.sum $(BUILDDIR)/
Expand Down
7 changes: 7 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,10 @@ locally as the Github Release section. To do this, checkout to the expected
version and then simply run `make build` (which will output the binary to the
`build` directory) or `make install`. The resulted binary should have the same
sha256 hash than the one from the Github Release section.

## Ledger support

Run `make build-ledger` to have ledger support in `./build/govgend` binary.
Note that this will disable reproducible builds, as it introduces OS
dependencies.

Loading