-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Atoum command #12
Conversation
foreach ($input->getArgument('bundles') as $name) { | ||
$bundle = $this->extractBundleFromKernel($name); | ||
|
||
$runner->addTestAllDirectory(sprintf('%s/Tests/Units', $bundle->getPath())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a Symfony
convention ... we should may be tests for existance of tests/units
or Tests/Units
directory, or having this information on configuration too ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use both :
- If anything is configured, then we use those values
- If nothing is configured, we fallback to conventions, correctly checking that directories exist before adding them (checks should also be run in the config. context)
Maybe we could add support for Controller testing too by default ?
|
I guess it would be better to supports For sure, these dirs could be overload via a configuration ... |
I suggested @mageekguy what's your opinion ? The PR is still in WIP but it looks good. Any chance to have it merged soon ? Maybe we could release it right now just to have SF command support and then improve it with config and fallback in a next PR ? |
Another reason for Functional tests are simple PHP files that typically live in the Tests/Controller directory of your bundle. |
I see, imho we Should follow symfony convention. I'll finish this feature this week. Thanks, Le 14 janv. 2013 à 19:18, "Nathanaël Mariani" [email protected] a Another reason for Tests/Controller : Symfony conventions Functional tests are simple PHP files that typically live in the — |
Great! Thanks. I look forward to using it with a clean composer.json ;) |
Stick to Symfony since it's a bundle ! yay 👍 |
It could be merged, any thought on this PR ? |
No problem for me ;) |
Work in progress implementation of atoum command. (discussion begin here #9)
config_test.yml