[WIP] Atoum command

[stephpy]

Work in progress implementation of atoum command. (discussion begin here #9)

$ app/console atoum FooBundle # FooBundle
$ app/console atoum FooBundle bar ...... #FooBundle and bundle which has `bar` as bundle alias extension.
$ app/console atoum # all bundles configured on config_test.yml

config_test.yml

atoum:
    bundles: [FooBundle, BarBundle]

[stephpy]

This is a Symfony convention ... we should may be tests for existance of tests/units or Tests/Units directory, or having this information on configuration too ...

[jubianchi]

I think we can use both :

• If anything is configured, then we use those values
• If nothing is configured, we fallback to conventions, correctly checking that directories exist before adding them (checks should also be run in the config. context)

[nmariani]

Maybe we could add support for Controller testing too by default ?

        $runner->addTestAllDirectory(sprintf('%s/Tests/Controller', $bundle->getPath()));

[stephpy]

I guess it would be better to supports Tests/Units and Tests/Functionals by default.

For sure, these dirs could be overload via a configuration ...

[nmariani]

I suggested Tests/Controller because I followed Atoum documentation but I agree with you Tests/Functionals is coherent and explicit regarding Unit VS Functional testing.

@mageekguy what's your opinion ?

The PR is still in WIP but it looks good. Any chance to have it merged soon ? Maybe we could release it right now just to have SF command support and then improve it with config and fallback in a next PR ?

[nmariani]

Another reason for Tests/Controller : Symfony conventions

Functional tests are simple PHP files that typically live in the Tests/Controller directory of your bundle.

[stephpy]

I see, imho we Should follow symfony convention.

I'll finish this feature this week.

Thanks,

Le 14 janv. 2013 à 19:18, "Nathanaël Mariani" [email protected] a
écrit :

Another reason for Tests/Controller : Symfony conventions

Functional tests are simple PHP files that typically live in the
Tests/Controller directory of your bundle.

—
Reply to this email directly or view it on
GitHubhttps://github.com//pull/12#issuecomment-12231801.

[nmariani]

Great! Thanks. I look forward to using it with a clean composer.json ;)

[ludofleury]

Stick to Symfony since it's a bundle ! yay 👍

[stephpy]

It could be merged, any thought on this PR ?

[jubianchi]

No problem for me ;)