This repository has been archived by the owner on Dec 16, 2020. It is now read-only.
Add an ensure parameter to ufw::allow
#49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an `ensure` parameter to `ufw::allow`, which currently defaults to `present`, and can accept `absent`. When set to `absent`, the rule will get deleted (if it exists) rather than created. Needing to delete a single rule across several hundred machines is a pain, and this feels like a good step with rule purging is figured out. This partially addresses the lack of purging unused rules, though this is a 'manual` delete rather than an entire purge. Related to #21
|
Spec failures here should be fixed by #50 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an
ensureparameter toufw::allow, which currently defaults topresent, and can acceptabsent. When set toabsent, the rule willget deleted (if it exists) rather than created. Needing to delete a
single rule across several hundred machines is a pain, and this feels
like a good step with rule purging is figured out. This partially
addresses the lack of purging unused rules, though this is a 'manual`
delete rather than an entire purge.
Related to #21