Use semaphore when encrypting/decrypting values (#1) #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW I can see that some tests are failing, but they're all to do with either gem installation (public_suffix requires Ruby version >= 2.3.), or something to do with the wrong version of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible fix for #344.
Ideally, I'd like to create the mutex instance variable as part of the object initialization, which will avoid having the class mutex and the nasty double-checked lock in line 377. However, the
after_initializehook is only available for Rails, and as far as I'm aware, overriding theinitializemethod is an anti-pattern. Would love to hear your thoughts on this.