Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support *paths in touch() #127

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Support *paths in touch() #127

merged 3 commits into from
Dec 5, 2023

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Dec 5, 2023

Similar to #126 this adds support for *paths to audeer.touch().
This allows a syntax like audeer.touch('folder', 'file.txt').

We have a few more functions that have path as input, but we cannot add support for *paths to all of them, e.g. move_file() requires src_path and dst_path. Besides audeer.touch(), we might consider to add it to audeer.list_file_names() and audeer.list_dir_names(), but I'm not completely convinced ;)

image

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #127 (605a2b0) into main (48fdf9f) will not change coverage.
The diff coverage is 100.0%.

Additional details and impacted files
Files Coverage Δ
audeer/core/io.py 100.0% <100.0%> (ø)

Copy link
Contributor

@audeerington audeerington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I think adding *paths for touch makes sense, but would also tend not to add it for the other functions.

audeer/core/io.py Show resolved Hide resolved
@hagenw hagenw merged commit ef3b271 into main Dec 5, 2023
19 checks passed
@hagenw hagenw deleted the touch-paths branch December 5, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants