Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add audeer.move() #128

Merged
merged 18 commits into from
Dec 6, 2023
Merged

Add audeer.move() #128

merged 18 commits into from
Dec 6, 2023

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Dec 5, 2023

Closes #98
Closes #96

Add audeer.move() as a replacement for audeer.move_file()
as audeer.move_file() does also support moving folders.
So it makes sense to update its docstring accordingly and also reflect it in the name.
As backward compatibility is a very important aspect of audeer, we do not remove audeer.move_file(), but just add a statement that in the docs that audeer.move() should be used.

image

image

@hagenw hagenw marked this pull request as draft December 5, 2023 11:45
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #128 (29a82f5) into main (ef3b271) will not change coverage.
The diff coverage is 100.0%.

Additional details and impacted files
Files Coverage Δ
audeer/__init__.py 100.0% <100.0%> (ø)
audeer/core/io.py 100.0% <100.0%> (ø)

@hagenw hagenw marked this pull request as ready for review December 5, 2023 16:16
Copy link
Contributor

@audeerington audeerington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I agree the new function name makes more sense now.

tests/test_io.py Outdated Show resolved Hide resolved
audeer/core/io.py Outdated Show resolved Hide resolved
@hagenw hagenw merged commit 11b8734 into main Dec 6, 2023
19 checks passed
@hagenw hagenw deleted the move branch December 6, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure dst folder does not exist under Windows in audeer.move_file() Add audeer.move()
2 participants