Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.1.0 #152

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Release 2.1.0 #152

merged 1 commit into from
Jul 5, 2024

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Jul 5, 2024

image

@hagenw hagenw requested a review from ChristianGeng July 5, 2024 10:18
Copy link
Member

@ChristianGeng ChristianGeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that I have reviewed all changes in this release's component releases.

I have had a look through the diff to the last tag, and for audeer this is probably not relevant but I see that the build workflow now does this:

python-version: [ '3.10' ]

As said, here I will approve right away. But in other packages, should the release log not mention when a specific python version is deprecated? I remember that I hadn't complained about this in some audformat/audb releases recently. But do you think this should be mentioend in CHANGELOGS in general?

As said this is a general question, and approval is given.

@hagenw
Copy link
Member Author

hagenw commented Jul 5, 2024

We still test for all Python versions:

image

For the build workflow we just have to pick one Python version to create the environment that builds the Python package.

@hagenw hagenw merged commit b200351 into main Jul 5, 2024
19 checks passed
@hagenw hagenw deleted the release-2.1.0 branch July 5, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants