Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use smoothing=0 in audeer.progress_bar() #153

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

hagenw
Copy link
Member

@hagenw hagenw commented Jul 12, 2024

Closes audeering/audb#442

This makes the estimation of the remaining time in the progress bar less eratic.

For a single thread it changed the behavior from

bar-main

to

bar

And when using 4 threads it changes the behavior from

bar-main-num-workers

to

bar-num-workers

Copy link
Member

@ChristianGeng ChristianGeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an exponential smoothing parameter. Setting it to 0 afaics seems to result in a mean estimate of all previous iteration durations.

This is safe and can be approved.

@hagenw
Copy link
Member Author

hagenw commented Jul 12, 2024

This is safe and can be approved.

It's always complicated with judging all the effects a setting on the progress bar has. Sometimes you realize only after a few days of using it, that it has some unwanted consequences. But the good news is, it will not result in any failing code ;)

If we really find a strange side effect of this, we can revert the change in a later release.

@hagenw hagenw merged commit c93499e into main Jul 12, 2024
19 checks passed
@hagenw hagenw deleted the smooth-progress-bar-remaining-time branch July 12, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress bar estimated remaining time too erratic
2 participants