-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for Python 3.8 #73
Conversation
Reviewer's Guide by SourceryThis pull request removes support for Python 3.8, which has reached its end-of-life. The changes primarily involve updating type hints and removing Python 3.8 from the test matrix. Architecture diagram for updated test matrix in CI workflowgraph TD;
A[CI Workflow] --> B[Matrix Configuration];
B --> C[OS: ubuntu-latest, windows-latest, macos-latest];
B --> D[Python Versions: 3.9, 3.10, 3.11, 3.12];
Updated class diagram for type hints in audplot/core/api.pyclassDiagram
class API {
+cepstrum()
+confusion_matrix(truth: Sequence | pd.Series, prediction: Sequence | pd.Series, labels: Sequence, label_aliases: dict, percentage: bool, show_both: bool, ax: matplotlib.axes.Axes)
+combine_string(x, y)
+detection_error_tradeoff(x: Sequence | pd.Series, y: Sequence | pd.Series, error_rates: bool, xlim: Sequence, ylim: Sequence, label: str, ax: matplotlib.axes.Axes) : Callable
+distribution(truth: Sequence | pd.Series, prediction: Sequence | pd.Series, ax: matplotlib.axes.Axes)
+human_format(number: int | float) : str
+scatter(truth: Sequence | pd.Series, prediction: Sequence | pd.Series, fit: bool, order: int, ax: matplotlib.axes.Axes)
+series(truth: Sequence | pd.Series, prediction: Sequence | pd.Series, ax: matplotlib.axes.Axes)
+waveform(x: np.ndarray, text: str, color: str | Sequence[float], background: str | Sequence[float], linewidth: float, ylim: Sequence[float], ax: matplotlib.axes.Axes)
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hagenw - I've reviewed your changes - here's some feedback:
Overall Comments:
- There's a small typo in the
waveform
function. The type hint for thebackground
parameter should bestr | Sequence[float]
instead ofstr, | Sequence[float]
. Please remove the extra comma.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bot has done a good job in finding the few clerical errors left.
It feels safe to approve.
Removes support for Python 3.8, which has reached its end-of-life.
As with Python 3.9 we can also use
list[str]
for type hinting instead oftyping.List[str]
, I also removed thetyping
module and replaced it with other code, including the type hinting union syntax introduced in Python 3.10, which is now also shown in the compiled documentation and makes it easier to read:Summary by Sourcery
Remove support for Python 3.8 by updating type hint syntax to use PEP 604 style and adjusting CI configuration to exclude Python 3.8.
CI:
Chores: