Release 0.1.0 #20
Merged
Release 0.1.0 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hagenw
commented
Sep 5, 2024
hagenw
commented
There was a problem hiding this comment.
I have checked the number of public members against the changelog here.
These match. The sorting is strictly alphabetical which makes sense after the structure has been flattened.
There is one thing I wonder: there is an obsolete requirements-dev file.
After transitioning to ruff this should probably be deleted before releasing.
I believe that #17 can be implemented after this release.
hagenw
force-pushed
the
release-0.1.0
branch
from
31b48a2
to
a3bf50b
Compare
|
Thanks for spotting, I removed |
|
As I have addressed your only request, I will now going to merge and hope that PyPI and the publishing workflow is setup correctly ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.