Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: add test for unsorted segmented index #33

Closed
wants to merge 1 commit into from

Conversation

audeerington
Copy link
Contributor

This adds a test case for the issue described in #32 when augmenting an unsorted segmented index.

The test currently fails because the resulting augmented index is in a different order than the input index.

@audeerington audeerington requested a review from hagenw July 4, 2024 11:17
@audeerington
Copy link
Contributor Author

In addition to the expected failed test in test_interface.py, there are also failed tests for test_transform_babble_noise.py and test_transform_pink_noise.py. I guess a change in the installed packages is the cause of this, but not sure yet why exactly.

@hagenw
Copy link
Member

hagenw commented Jul 4, 2024

I created #34 to fix the numpy 2.0 related test failures.

@hagenw
Copy link
Member

hagenw commented Jul 5, 2024

Thanks for adding the test, I will try to fix it, or did you start working on it already?

@audeerington
Copy link
Contributor Author

Thanks, I haven't started on it yet!

@hagenw
Copy link
Member

hagenw commented Jul 8, 2024

I created #36 that incorporates your proposed test, updates it slightly, and also provides a fix for it.

@hagenw
Copy link
Member

hagenw commented Jul 8, 2024

Closing in favor of #36

@hagenw hagenw closed this Jul 8, 2024
@hagenw hagenw deleted the test_unsorted_index branch July 8, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants